cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prasanna Santhanam <...@apache.org>
Subject Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Date Mon, 22 Apr 2013 14:22:49 GMT
On Tue, Apr 16, 2013 at 02:53:43PM +0000, bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> -------
> 
> Cloudstack-701: Support for non contiguous vlan ranges.
> 
> 
> Diffs (updated)
> -----
> 
>   test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION 
Thanks for taking the time to write a marvin test. But please ensure
you've run it against the simulator or an environment the test is
suitable for. Also pay attention to the existing examples in other
areas - there's some good libraries included in Marvin to simplify
test case writing.

In your case I had to fix up the test to run as it had SyntaxErrors
in it.

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Mime
View raw message