cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayapal Reddy" <jayapalreddy.ur...@citrix.com>
Subject Review Request: Add uuid to AddIpToVmNicCmd nicsecondary ip resonpose
Date Mon, 22 Apr 2013 09:02:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10700/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Murali Reddy.


Description
-------

added the secondary ip id entry uuid to response.


This addresses bug CLOUDSTACK-1741.


Diffs
-----

  api/src/com/cloud/network/NetworkService.java 5a6054d 
  api/src/org/apache/cloudstack/api/ResponseGenerator.java c0dd57e 
  api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java df6b399 
  api/test/org/apache/cloudstack/api/command/test/AddIpToVmNicTest.java 106589d 
  server/src/com/cloud/api/ApiResponseHelper.java 7629e5e 
  server/src/com/cloud/network/NetworkServiceImpl.java 12c6068 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 6a0263e 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java bfcccf5 

Diff: https://reviews.apache.org/r/10700/diff/


Testing
-------

1. Acquired secondary ip to the nic.
2. Deleted it from the UI. Deletion is successful. 
Earlier deleting the acquired ip failed when doing it after acquire without navigating the
pages. 


Thanks,

Jayapal Reddy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message