cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <>
Subject Re: Review Request: CLOUDSTACK-741: Granular Global Parameters
Date Thu, 18 Apr 2013 20:16:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 18, 2013, 8:16 p.m.)

Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.


updated patch with suggested changes


CLOUDSTACK-741: Granular Global Parameters

Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter
scope and resource id (zone/cluster/pool/account).
Scope decides the parameter which level we can update the value and id is the corresponding
id based on the scope.
This scope is defined in the file where we are creating groups for each level(zone/cluster/pool/account).
Currently submitted the patch for the zone level parameter use.external.dns.

Included unit tests and marvin tests.

This addresses bug CLOUDSTACK-741.

Diffs (updated)

  api/src/org/apache/cloudstack/api/command/admin/config/ aabfd4a 
  api/src/org/apache/cloudstack/api/command/admin/config/ ffeb586 
  api/src/org/apache/cloudstack/api/response/ 95b8af2 
  api/test/org/apache/cloudstack/api/command/test/ PRE-CREATION 
  api/test/org/apache/cloudstack/api/command/test/ PRE-CREATION 
  engine/api/src/org/apache/cloudstack/storage/datastore/db/ be71670

  server/src/com/cloud/configuration/ 2993966 
  server/src/com/cloud/configuration/ afaf0d6 
  server/src/com/cloud/configuration/ 4fc2db7 
  server/src/com/cloud/configuration/dao/ c86c024 
  server/src/com/cloud/network/router/ ab91059 
  server/src/com/cloud/server/ f441b1f 
  server/src/com/cloud/server/ c4da1ab 
  server/src/com/cloud/server/ 98f789a 
  server/src/com/cloud/storage/dao/ 0d797ed 
  server/test/com/cloud/vpc/ 9443815 
  test/integration/smoke/ PRE-CREATION 



Tested locally
- tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone
scope and zone id
- tested the modified parameter to take the updated value at zone level(after updation).


Harikrishna Patnala

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message