cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sateesh Chodapuneedi" <sateesh.chodapune...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well
Date Thu, 18 Apr 2013 17:18:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10078/#review19395
-----------------------------------------------------------



server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10078/#comment40104>

    The ip before startVmIp doesn't have to be omitted from reserved ip range. Just leave
existing statement as it is. This line need not be modified.



server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10078/#comment40105>

    Do not skip the IP before startVmIp. Leave the existing expresssion (estartVmIp-1) as
it is. Only the expression (endVmIp + 1) need be modified.


- Sateesh Chodapuneedi


On March 22, 2013, 10:04 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10078/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 10:04 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java 663139d 
> 
> Diff: https://reviews.apache.org/r/10078/diff/
> 
> 
> Testing
> -------
> 
> CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63)
> Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255)
> Reserved Range: 10.1.1.64-10.1.1.254
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message