cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <bharat.ku...@citrix.com>
Subject Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Date Tue, 16 Apr 2013 14:54:21 GMT


> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote:
> > Ship It!
> 
> Abhinandan Prateek wrote:
>     The patch does not apply, can you resubmit after checking it.

uploaded the new diff


- bharat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review19060
-----------------------------------------------------------


On April 16, 2013, 2:53 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> -------
> 
> Cloudstack-701: Support for non contiguous vlan ranges.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/NetworkService.java 066009b 
>   api/src/com/cloud/network/PhysicalNetwork.java a2044a6 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 37cb59f 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
06cf38d 
>   server/src/com/cloud/api/ApiResponseHelper.java cfe0e00 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854 
>   server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4 
>   server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4 
>   server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java c2038e5 
>   server/src/com/cloud/network/NetworkServiceImpl.java 70d1d0d 
>   server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb 
>   server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 9042f03 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 3a585ce 
>   test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10238/diff/
> 
> 
> Testing
> -------
> 
> Tested on latest master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message