cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Review Request: NPE while migrating volume
Date Tue, 16 Apr 2013 07:01:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10539/
-----------------------------------------------------------

Review request for cloudstack and edison su.


Description
-------

The state transitions on the volume that has to be migrated were incorrect. A volume to be
migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated
volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning
the volume to migrating state when a migrateVolume api call is made. Also, a volume has to
be destroyed first before it can be expunged. Fixed that too.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1879.


Diffs
-----

  engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java
f619ef4 
  engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java ceadb25

  engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 32e7d27


Diff: https://reviews.apache.org/r/10539/diff/


Testing
-------

1. migrated a volume from one storage pool to another and made sure it was successful. Attached
it to a vm after migrating.
2. Also verified that the patch applies successfully.


Thanks,

Devdeep Singh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message