cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: (CLOUDSTACK-2017) implement network bandwidth rate limits for VMs for KVM
Date Mon, 15 Apr 2013 05:18:47 GMT


> On April 12, 2013, 1:27 p.m., Chip Childers wrote:
> > Wei,
> > 
> > Any chance you can provide unit tests and / or a marvin test that covers this functionality?
I know it's a bit of an odd part of the code to have an automated test for, but we'd love
to see something added with each incremental functional change we make.
> > 
> > -chip

Wido has setup some basic tests over which one can build further unit-tests. Checkout LibvirtVMDefTest.java
in plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10428/#review19072
-----------------------------------------------------------


On April 12, 2013, 6:33 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10428/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 6:33 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Adding bandwidth inbound and outbound limitations in VM XML file to implement network
bandwidth rate limits for VMs for KVM.
> It is supported since libvirt 0.9.4.
> 
> The patch only applies on CloudStack 4.0.1 branch.
> If commited, I will change it to support 4.1 and master branch.
> 
> 
> This addresses bug CLOUDSTACK-2017.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
f406c86 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
b622b6d 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ba6c715

> 
> Diff: https://reviews.apache.org/r/10428/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> The VMs need to stop and start to make network bandwidth limits effective.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message