cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Min Chen" <min.c...@citrix.com>
Subject Re: Review Request: Fix for CLOUDSTACK-1987
Date Fri, 12 Apr 2013 05:28:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10426/#review19052
-----------------------------------------------------------



server/src/com/cloud/api/query/QueryManagerImpl.java
<https://reviews.apache.org/r/10426/#comment39602>

    For domain users, they should not be able to query system offerings. This fix didn't guard
that case.


- Min Chen


On April 12, 2013, 4:57 a.m., Ryan Dietrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10426/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 4:57 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> So, without this fix you can't query service offerings that don't have a domain id set
(null).
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e 
> 
> Diff: https://reviews.apache.org/r/10426/diff/
> 
> 
> Testing
> -------
> 
> Called "listServiceOfferings" using a simple perl script, once with an ID, and once without
an ID specified.
> 
> 
> Thanks,
> 
> Ryan Dietrich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message