cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkata Siva Vijayendra Bhamidipati" <vijayendra.bhamidip...@citrix.com>
Subject Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request
Date Wed, 10 Apr 2013 21:59:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10294/
-----------------------------------------------------------

(Updated April 10, 2013, 9:59 p.m.)


Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and Min Chen.


Changes
-------

Adding unit tests.


Description
-------

Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements
for a background on the requirements driving this patch.

This patch hasn't been extensively tested yet, and I will update this request with more info.
I am uploading a first diff for initial review/comments.


This addresses bug CLOUDSTACK-1086.


Diffs (updated)
-----

  api/src/com/cloud/vm/UserVmService.java 2c33d41 
  api/src/org/apache/cloudstack/api/BaseCmd.java 8fef422 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 21a45f8 
  core/src/com/cloud/vm/UserVmVO.java a16eaf9 
  server/src/com/cloud/api/ApiDispatcher.java 925d90a 
  server/src/com/cloud/api/ApiServer.java d842819 
  server/src/com/cloud/api/ApiServerService.java 12d8b52 
  server/src/com/cloud/api/ApiServlet.java 03bfb5f 
  server/src/com/cloud/vm/UserVmManagerImpl.java 1c3764a 
  server/test/com/cloud/vm/MockUserVmManagerImpl.java dd8dd83 
  server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180 
  server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION 
  server/test/resources/UserVMDaoTestContext.xml PRE-CREATION 
  setup/db/db/schema-410to420.sql c7c8b5b 

Diff: https://reviews.apache.org/r/10294/diff/


Testing
-------


Thanks,

Venkata Siva Vijayendra Bhamidipati


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message