cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharat kumar" <bharat.ku...@citrix.com>
Subject Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Date Tue, 09 Apr 2013 14:59:58 GMT


> On April 8, 2013, 9:36 p.m., Likitha Shetty wrote:
> > server/src/com/cloud/network/NetworkServiceImpl.java, line 2377
> > <https://reviews.apache.org/r/10238/diff/2/?file=277888#file277888line2377>
> >
> >     Please handle the following 2 corner cases where admin user tries to shrink
the existing vnet ranges
> >     1. New start vnet is equal to the start vnet of the existing range and the new
end vnet is less than the existing end vnet
> >     2. New start vnet is greater than the start vnet of the existing range and the
new end vnet is equal to the existing end vnet

The error message is incorrect, It is not about trying to shrink the vlan range.  Forgot to
remove the error message from previous code.  Thanks for pointing this out. Fixed it.


- bharat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18795
-----------------------------------------------------------


On April 4, 2013, 12:36 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 12:36 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> -------
> 
> Cloudstack-701: Support for non contiguous vlan ranges.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/NetworkService.java ab6d7bf 
>   api/src/com/cloud/network/PhysicalNetwork.java a2044a6 
>   api/src/org/apache/cloudstack/api/ApiConstants.java c518830 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
06cf38d 
>   server/src/com/cloud/api/ApiResponseHelper.java 64be7f8 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0 
>   server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4 
>   server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4 
>   server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2 
>   server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c 
>   server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb 
>   server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a 
>   server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051 
>   test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10238/diff/
> 
> 
> Testing
> -------
> 
> Tested on latest master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message