cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: Automation tests for reset ssh key for access to VM
Date Mon, 08 Apr 2013 11:28:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10335/#review18775
-----------------------------------------------------------



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39191>

    Can you append the ASF ASLv2 Header? See examples in the test directory



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39192>

    Is the library method in base.py included with this review request? Can you add the diff
for that?



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39193>

    Could you move this creation of ssh keypair into utils.py?



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39198>

    These tests should work on all zone modes, so can you please put the @attr(tags = [advanced,
basic, sg]) for the test headers. 



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39194>

    get_template is also missing this additional name=Key, argument in common.py



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39195>

    does getting the sshclient make the connection? print a helpful message on success?



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39196>

    skip the test here if such a template is not found. 



test/integration/component/test_reset_ssh_keypair.py
<https://reviews.apache.org/r/10335/#comment39197>

    corresponding base.py changes are missing in the review request.


- Prasanna Santhanam


On April 8, 2013, 10:54 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10335/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 10:54 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Automation tests for Reset SSH key for access to VM https://issues.apache.org/jira/browse/CLOUDSTACK-1800
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_reset_ssh_keypair.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10335/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message