cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: [ACS41][Patch request] f1259d50bdd6120174717f4cce6a45dc12b6645b
Date Thu, 04 Apr 2013 15:00:46 GMT
On Thu, Apr 04, 2013 at 04:52:15PM +0200, Wido den Hollander wrote:
> Hi,
> 
> Hugo and I were on IRC today and he found
> f1259d50bdd6120174717f4cce6a45dc12b6645b
> 
> I also noticed this on 4.1 and this fix seems to resolve it.
> 
> There is no Jira ticket I could find and since Hugo isn't online
> right now I'm requesting it this way.
> 
> Or do we want a Jira ticket first?
> 
> Wido
>

I think we can cherry-pick over without one, but can you explain this
part of the diff?

-
-    public AgentMonitor(long msId, HostDao hostDao, VMInstanceDao vmDao, DataCenterDao dcDao,
HostPodDao podDao, AgentManagerImpl agentMgr, AlertManager alertMgr, long pingTimeout) {
-        super("AgentMonitor");
-        _msId = msId;
-        _pingTimeout = pingTimeout;
-        _hostDao = hostDao;
-        _agentMgr = agentMgr;
-        _stop = false;
-        _vmDao = vmDao;
-        _dcDao = dcDao;
-        _podDao = podDao;
-        _alertMgr = alertMgr;
-        _pingMap = new ConcurrentHashMap<Long, Long>(10007);
-        // try {
-        // Connection conn = Transaction.getStandaloneConnectionWithException();
-        // conn.setAutoCommit(true);
-        // conn.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);
-        // _concierge = new ConnectionConcierge("AgentMonitor", conn, true);
-        // } catch (SQLException e) {
-        // throw new CloudRuntimeException("Unable to get a db connection", e);
-        // }
-
-    }
-

I'm not sure what this method did, but it's being removed.

Mime
View raw message