cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Saxena" <pranav.sax...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-1908 : The specified event isn't removed from list after deletion
Date Wed, 03 Apr 2013 17:16:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10253/#review18650
-----------------------------------------------------------

Ship it!


Patch applies cleanly and works well . I'll apply it on master . Thanks Isaac for the patch
. 

- Pranav Saxena


On April 3, 2013, 3:23 p.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10253/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 3:23 p.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1908 : The specified event isn't removed from list after deletion
> 
> 1.Remove target row from listview after deleting an event.
> 2.replace "no data to show" row if there is no event in the list
> 
> CLOUDSTACK-1287 : The list table is malformed when scrolling down in the global setting
page
> 
> Prevent the table being distorted after reloading data
> 
> 
> This addresses bugs CLOUDSTACK-1287 and CLOUDSTACK-1908.
> 
> 
> Diffs
> -----
> 
>   ui/css/cloudstack3.css 9b77b9f 
>   ui/scripts/events.js 1c89b58 
>   ui/scripts/ui/widgets/detailView.js 0731dda 
> 
> Diff: https://reviews.apache.org/r/10253/diff/
> 
> 
> Testing
> -------
> 
> Test in master branch and works well.
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message