cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das" <koushik....@citrix.com>
Subject Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Date Mon, 01 Apr 2013 07:41:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review18578
-----------------------------------------------------------



api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java
<https://reviews.apache.org/r/9779/#comment38959>

    What it means to restore from new iso? Do we need a new iso parameter?



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9779/#comment38963>

    Handling of iso case is not clear. Are you expecting the iso id in the newTemplateId parameter?


- Koushik Das


On March 6, 2013, 12:23 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 12:23 p.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Koushik Das.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
> 
> 
> This addresses bug CLOUDSTACK-1453.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97 
>   server/src/com/cloud/vm/UserVmManagerImpl.java ca9c13f 
> 
> Diff: https://reviews.apache.org/r/9779/diff/
> 
> 
> Testing
> -------
> 
> tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message