Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
MIME-Version: 1.0
Sender: dcahill@midokura.jp
In-Reply-To: <20130226094901.1280.91871@reviews.apache.org>
References: <20130226094901.1280.91871@reviews.apache.org>
Date: Fri, 1 Mar 2013 12:39:42 +0900
Message-ID: 
 <CALytfWYQn+rjN3ZB5PVKsEq3VtxySBOnd0TWMU9xVuiaa+_uOA@mail.gmail.com>
Subject: Re: Review Request: Add the ability to specify different VIF drivers
 per traffic type in KVM
From: Dave Cahill <dcahill@midokura.com>
To: Hugo Trippaers <htrippaers@schubergphilis.com>
Cc: cloudstack <cloudstack-dev@incubator.apache.org>,
 Dave Cahill <dcahill@midokura.com>
Content-Type: multipart/alternative; boundary=bcaec554d952fdb12504d6d4c111

--bcaec554d952fdb12504d6d4c111
Content-Type: text/plain; charset=ISO-8859-1

Hi,

This patch was submitted 3 days ago, so sending a gentle reminder email as
per ReviewBoard guidelines. :) [1]

If there are any questions or issues, just let me know.

Thanks,
Dave.

[1]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

On Tue, Feb 26, 2013 at 6:49 PM, Dave Cahill <dcahill@midokura.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9604/
>   Review request for cloudstack and Hugo Trippaers.
> By Dave Cahill.
> Description
>
> Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+specification+of+different+VIF+drivers+per+traffic+type+in+KVM
>
> Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-1311
>
> Adds the ability to specify different VIF drivers per traffic type in KVM.
>
>   Testing
>
> Added unit tests to test all variations of this new configuration (no configuration, defaults, override some traffic etc).
>
> Built and deployed, spun up Advanced Isolated network with two VMs, verified internal and external connectivity.
>
>   *Bugs: * CLOUDSTACK-1311
> Diffs
>
>    - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
>    (99b8723)
>    - plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVifDriverTest.java
>    (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/9604/diff/>
>

--bcaec554d952fdb12504d6d4c111--