Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of Alex.Huang@citrix.com
 designates 66.165.176.89 as permitted sender)
From: Alex Huang <Alex.Huang@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>
CC: Nitin Mehta <Nitin.Mehta@citrix.com>, Abhinandan Prateek
	<Abhinandan.Prateek@citrix.com>
Date: Mon, 4 Mar 2013 10:00:24 -0800
Subject: RE: Master branch build is broken again
Thread-Topic: Master branch build is broken again
Thread-Index: Ac4ZAN2IqnWDGaMcTr2Pkr3ifvY3uAAAHgqAAAAc/eA=
Message-ID: 
 <B1DF26ECC0458748AC97CECE2DA98D41013175649537@SJCPMAILBOX01.citrite.net>
References: <CD5A1F11.AD9D%min.chen@citrix.com>
 <B1DF26ECC0458748AC97CECE2DA98D41013175649535@SJCPMAILBOX01.citrite.net>
In-Reply-To: 
 <B1DF26ECC0458748AC97CECE2DA98D41013175649535@SJCPMAILBOX01.citrite.net>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

-1 on this checkin

And this is not a small change.  18 files.  Some large completely new metho=
ds checked in.  Changes to the virtual machine state machine.  No unit test=
ing.  =20

I would reject this fix on these problems alone.

--Alex

> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Monday, March 4, 2013 9:56 AM
> To: cloudstack-dev@incubator.apache.org
> Cc: Nitin Mehta; Abhinandan Prateek
> Subject: RE: Master branch build is broken again
>=20
> Min,
>=20
> You should just revert the commit.
>=20
> --Alex
>=20
> > -----Original Message-----
> > From: Min Chen [mailto:min.chen@citrix.com]
> > Sent: Monday, March 4, 2013 9:51 AM
> > To: cloudstack-dev@incubator.apache.org
> > Cc: Nitin Mehta
> > Subject: Master branch build is broken again
> > Importance: High
> >
> > Hi there,
> >
> > I could not compile master after pulling latest code today,  build
> > failed with the following error:
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-compiler-
> > plugin:2.5.1:compile (default-compile) on project cloud-engine-
> orchestration:
> > Compilation failure [ERROR] /Users/minc/dev/cloud-
> > asf/engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity
> > /a
> > pi/db/VMEntityVO.java:[52,7]
> > org.apache.cloudstack.engine.cloud.entity.api.db.VMEntityVO is not
> > abstract and does not override abstract method getNewSvcOfferingId()
> > in com.cloud.vm.VirtualMachine [ERROR] -> [Help 1]
> >
> > I checked the commit history, it seems related to commit
> > e0019eccd997d9b2b3ff9395bcd99f821f5121db, so CC Nitin here. Can
> > somebody quickly fix this? This is blocking me from verifying
> > CLOUDSTACK-
> > 1491 and merge my feature branch vim51_win8.
> >
> >        Thanks
> > -min
> >