Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of pranav.saxena@citrix.com
 designates 203.166.19.134 as permitted sender)
From: Pranav Saxena <pranav.saxena@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>
CC: Rajesh Battala <rajesh.battala@citrix.com>, Brian Federle
	<Brian.Federle@citrix.com>, Animesh Chaturvedi
	<animesh.chaturvedi@citrix.com>, Haroon Abdelrahman
	<haroon.abdelrahman@citrix.com>
Subject: RE: [Merged] - CloudStack -664:AWS Health Check feature into Master
Thread-Topic: [Merged] - CloudStack -664:AWS Health Check feature into Master
Thread-Index: Ac4js3+OuCwvFzAHSBaQd0umzyTuBAACq0UAABI+tRA=
Date: Mon, 18 Mar 2013 18:35:33 +0000
Message-ID: <2307598D4FCF004D81B2C8892AA9A91101FEA7@SINPEX01CL01.citrite.net>
References: <2307598D4FCF004D81B2C8892AA9A91101F80F@SINPEX01CL01.citrite.net>
 <CA+96GG4robpGWnbF_UvzvFTrtZFXLj2zK4_msuAvgjx7uHjnZQ@mail.gmail.com>
In-Reply-To: 
 <CA+96GG4robpGWnbF_UvzvFTrtZFXLj2zK4_msuAvgjx7uHjnZQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Chip ,

I guess there was a discussion about the reason behind not having unit test=
s for this feature now - (http://mail-archives.apache.org/mod_mbox/incubato=
r-cloudstack-dev/201301.mbox/%3C97F4356AEA71904482CD192135C038F9011CC0D20E7=
C@BANPMAILBOX01.citrite.net%3E ) . Not sure , if they hold good now as well=
  otherwise Rajesh would need to add them .

Thanks,
Pranav

-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]=20
Sent: Monday, March 18, 2013 11:22 PM
To: cloudstack-dev@incubator.apache.org
Cc: Rajesh Battala; Brian Federle; Animesh Chaturvedi; Haroon Abdelrahman
Subject: Re: [Merged] - CloudStack -664:AWS Health Check feature into Maste=
r

On Mon, Mar 18, 2013 at 4:35 AM, Pranav Saxena <pranav.saxena@citrix.com> w=
rote:
> The AWS health Check feature backend code has been merged into master . T=
he patch applied cleanly and the RAT build was successful . I'll be soon me=
rging the UI support for this feature as well.

Rajesh and Pranav,

I don't see any unit tests or marvin tests for this feature.  Am I missing =
something?

I *do* see a good description of what I would expect to have seen made into=
 a marvin test included in the "Testing" field of review board.

We had agreed that tests would be included in new feature merges (documente=
d in the feature branch merge expectations [1] and referenced in the review=
 board guidelines [2]).

Please explain when we will see these.  I'd like to avoid reverting the com=
mits.

-chip

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Exp=
ectations
[2] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Gui=
delines