Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43DD1F09E for ; Fri, 22 Mar 2013 15:27:07 +0000 (UTC) Received: (qmail 18030 invoked by uid 500); 22 Mar 2013 15:27:06 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 17975 invoked by uid 500); 22 Mar 2013 15:27:06 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 17966 invoked by uid 500); 22 Mar 2013 15:27:06 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 17961 invoked by uid 99); 22 Mar 2013 15:27:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Mar 2013 15:27:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 48A521C6CC3; Fri, 22 Mar 2013 15:27:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0259517533687684376==" MIME-Version: 1.0 Subject: Re: Review Request: Bugfix CLOUDSTACK-1761: Fixed KVM plugin to return available storage which client is expecting instead of used From: "Marcus Sorensen" To: "Marcus Sorensen" Cc: "cloudstack" , "Ted Smith" Date: Fri, 22 Mar 2013 15:27:04 -0000 Message-ID: <20130322152704.6650.16834@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Marcus Sorensen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10069/ X-Sender: "Marcus Sorensen" References: <20130322150725.6651.73456@reviews.apache.org> In-Reply-To: <20130322150725.6651.73456@reviews.apache.org> Reply-To: "Marcus Sorensen" --===============0259517533687684376== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10069/#review18270 ----------------------------------------------------------- Ship it! Ship It! - Marcus Sorensen On March 22, 2013, 3:07 p.m., Ted Smith wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10069/ > ----------------------------------------------------------- > = > (Updated March 22, 2013, 3:07 p.m.) > = > = > Review request for cloudstack and Marcus Sorensen. > = > = > Description > ------- > = > Bugfix CLOUDSTACK-1761: Fixed KVM plugin to return available storage whic= h client is expecting instead of used disk space. This caused CloudStack to= mistakenly believe that there was not enough free disk space and it was un= able to provision new instances. > = > = > This addresses bug CLOUDSTACK-1761. > = > = > Diffs > ----- > = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtCo= mputingResource.java 8ee3ea4 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorage= Pool.java 5437e7c = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtSto= rageAdaptor.java d5e6ad6 = > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtSto= ragePool.java 32f8ce9 = > = > Diff: https://reviews.apache.org/r/10069/diff/ > = > = > Testing > ------- > = > Built on Ubuntu 12.04. Tested on Ubuntu 12.04 client. Verified availableB= ytes was correctly returned as the amount of available disk space and not t= he amounted of allocated disk space. > [INFO] ------------------------------------------------------------------= ------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------= ------ > [INFO] Total time: 3:08.767s > [INFO] Finished at: Thu Mar 21 16:37:12 PDT 2013 > [INFO] Final Memory: 53M/1071M > [INFO] ------------------------------------------------------------------= ------ > = > 2013-03-21 16:45:24,714 DEBUG [cloud.agent.Agent] (Agent-Handler-1:null) = Sending Startup: Seq -1-0: { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags: 1,= [{"StartupRoutingCommand":{"cpus":32,"speed":2701,"memory":135144730624,"d= om0MinMemory":805306368,"poolSync":false,"vms":{},"caps":"hvm,snapshot","po= ol":"/root","hypervisorType":"KVM","hostDetails":{"com.cloud.network.Networ= ks.RouterPrivateIpStrategy":"HostLocal","Host.OS":"Ubuntu","Host.OS.Kernel.= Version":"3.2.0-38-generic","Host.OS.Version":"12.04"},"type":"Routing","da= taCenter":"1","pod":"1","cluster":"14","guid":"61430069-ba1d-3cac-ab97-6b37= b5d16263-LibvirtComputingResource","name":"somename018","version":"4.2.0-SN= APSHOT","publicIpAddress":"10.81.96.68","publicNetmask":"255.255.255.0","pu= blicMacAddress":"78:45:c4:fb:26:76","privateIpAddress":"10.81.96.68","priva= teMacAddress":"78:45:c4:fb:26:76","privateNetmask":"255.255.255.0","storage= IpAddress":"10.81.96.68","storageNetmask":"255.255.255.0","storageMacAddres= s":"78:45:c4:fb:26:76","resourceName":"LibvirtComputingResource","gatewayIp= Address":"10.81.96.1","wait":0}},{"StartupStorageCommand":{"totalSize":0,"p= oolInfo":{"uuid":"a7dff188-aebd-4702-aecf-b33f781222a8","host":"10.81.96.68= ","localPath":"/var/lib/libvirt/images/","hostPath":"/var/lib/libvirt/image= s/","poolType":"Filesystem","capacityBytes":4956273893376,"availableBytes":= 4954406244352},"resourceType":"STORAGE_POOL","hostDetails":{},"type":"Stora= ge","dataCenter":"1","pod":"1","guid":"61430069-ba1d-3cac-ab97-6b37b5d16263= -LibvirtComputingResource","name":"computestage018","version":"4.2.0-SNAPSH= OT","resourceName":"LibvirtComputingResource","wait":0}}] } > 2013-03-21 16:45:24,714 DEBUG [cloud.agent.Agent] (Agent-Handler-1:null) = Startup task created > = > = > Thanks, > = > Ted Smith > = > --===============0259517533687684376==--