Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D8FE6FD1F for ; Thu, 21 Mar 2013 16:57:52 +0000 (UTC) Received: (qmail 39899 invoked by uid 500); 21 Mar 2013 16:57:49 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 39852 invoked by uid 500); 21 Mar 2013 16:57:49 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 39819 invoked by uid 500); 21 Mar 2013 16:57:49 -0000 Delivered-To: apmail-incubator-cloudstack-dev@incubator.apache.org Received: (qmail 39805 invoked by uid 99); 21 Mar 2013 16:57:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Mar 2013 16:57:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A33291C6339; Thu, 21 Mar 2013 16:57:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7268405050929077003==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-1537 - Restart network with clean up set to true causes Autoscaled LB rule to get mangled and unusable From: "ASF Subversion and Git Services" To: "Ram Ganesh" , "Chiradeep Vittal" , "Murali Reddy" , "Devdeep Singh" Cc: "cloudstack" , "Vijay Venkatachalam" , "ASF Subversion and Git Services" Date: Thu, 21 Mar 2013 16:57:48 -0000 Message-ID: <20130321165748.6650.17346@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10017/ X-Sender: "ASF Subversion and Git Services" References: <20130319171847.6651.81684@reviews.apache.org> In-Reply-To: <20130319171847.6651.81684@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============7268405050929077003== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10017/#review18214 ----------------------------------------------------------- Commit 886c3a56961c2ea941ca6f41af8e80afd3b50de7 in branch refs/heads/4.1 fr= om Chip Childers [ https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;h=3D886c3a5 ] CLOUDSTACK-1537. Fixing Network Restart case for AutoScale - ASF Subversion and Git Services On March 19, 2013, 5:18 p.m., Vijay Venkatachalam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10017/ > ----------------------------------------------------------- > = > (Updated March 19, 2013, 5:18 p.m.) > = > = > Review request for cloudstack, Devdeep Singh, Murali Reddy, Chiradeep Vit= tal, and Ram Ganesh. > = > = > Description > ------- > = > Bug Title: Restart network with clean up set to true causes Autoscaled LB= rule to get mangled and unusable = > = > AutoScale LB information was not packaged for restart of network case to = Resource Layer. This caused the undesired outcome and it is fixed now. NetW= orkManagerImpl was doing the cleanup of the LBRules during restart, after t= he fix; NetWorkManagerImpl will only act as a trigger, the actual job rela= ted to LB Rules (for ex. remove/revoke) will be handled by LBRules Manager = (which should have been the actual implementation, so moved code around). = > = > Also, NetScaler resource is simplified to handle create/enable/disable/re= start in one code path. = > = > = > This addresses bug CLOUDSTACK-1537. > = > = > Diffs > ----- > = > api/src/com/cloud/network/lb/LoadBalancingRule.java fb1d988 = > plugins/network-elements/netscaler/src/com/cloud/network/resource/Netsc= alerResource.java abea464 = > server/src/com/cloud/network/NetworkManagerImpl.java f6e32fb = > server/src/com/cloud/network/lb/LoadBalancingRulesManager.java 9d7d22f = > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 531a= 428 = > = > Diff: https://reviews.apache.org/r/10017/diff/ > = > = > Testing > ------- > = > = > 1. Create/Delete/ScaleUp/ScaleDown/Enable/Disable of AutoScale LB Rule > 2. Restart of Network with AutoScale LB Rule - Cleanup =3D=3D false > 3. Restart of Network with AutoScale LB Rule - Cleanup =3D=3D true > 4. Create/Delete of Non-AutoScale LB Rule > = > = > Thanks, > = > Vijay Venkatachalam > = > --===============7268405050929077003==--