Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 98A10F7A2 for ; Wed, 20 Mar 2013 00:35:11 +0000 (UTC) Received: (qmail 25087 invoked by uid 500); 20 Mar 2013 00:35:11 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 25056 invoked by uid 500); 20 Mar 2013 00:35:11 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 25046 invoked by uid 99); 20 Mar 2013 00:35:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2013 00:35:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 287C21C4C6A; Wed, 20 Mar 2013 00:35:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0372197121346667433==" MIME-Version: 1.0 Subject: Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier on master/4.1 From: "ASF Subversion and Git Services" To: "cloudstack" , "ASF Subversion and Git Services" , "Wei Zhou" Date: Wed, 20 Mar 2013 00:35:10 -0000 Message-ID: <20130320003510.6651.46542@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/10022/ X-Sender: "ASF Subversion and Git Services" References: <20130319202524.6651.42011@reviews.apache.org> In-Reply-To: <20130319202524.6651.42011@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" --===============0372197121346667433== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10022/#review18123 ----------------------------------------------------------- Commit af0723e9c9259619c2cb5d77396e2297f1273a5e in branch refs/heads/4.0 fr= om Chip Childers [ https://git-wip-us.apache.org/repos/asf?p=3Dincubator-cloudstack.git;h=3D= af0723e ] CLOUDSTACK-1668: Fix IP conflict in VPC tier Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list. Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1). We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks). Signed-off-by: Chip Childers - ASF Subversion and Git Services On March 19, 2013, 8:25 p.m., Wei Zhou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10022/ > ----------------------------------------------------------- > = > (Updated March 19, 2013, 8:25 p.m.) > = > = > Review request for cloudstack. > = > = > Description > ------- > = > Currently, allPossibleIps return the Ip lists which include the gateway, = so we need to remove gateway ip from this list. > = > Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr ret= urn the Ip lists which do not include the first IP of the network (like 192= .168.0.1). = > We need too add the first IP into the returned Ip list, because it can be= used for VM if it is not the gateway IP (for example, VPC networks). > = > The corresponding patch for 4.0.1 has been posted on https://reviews.apac= he.org/r/9923/ > = > = > This addresses bug CLOUDSTACK-1668. > = > = > Diffs > ----- > = > server/src/com/cloud/network/NetworkModelImpl.java 779b9f2 = > server/src/com/cloud/network/NetworkServiceImpl.java 52e81e5 = > utils/src/com/cloud/utils/net/NetUtils.java dd40a33 = > = > Diff: https://reviews.apache.org/r/10022/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Wei Zhou > = > --===============0372197121346667433==--