Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E280BD6EF for ; Thu, 14 Mar 2013 21:05:27 +0000 (UTC) Received: (qmail 40776 invoked by uid 500); 14 Mar 2013 21:05:27 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 40714 invoked by uid 500); 14 Mar 2013 21:05:27 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 40702 invoked by uid 99); 14 Mar 2013 21:05:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Mar 2013 21:05:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB5331C1CE5; Thu, 14 Mar 2013 21:05:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2490097441110129398==" MIME-Version: 1.0 Subject: Re: Review Request: CLOUODSTACK-1645 : Resources limit is not validated with update compute offering [ Instances are updated to higher CPU/Memory resources though there are no resources available @ account/domain] From: "Min Chen" To: "Sateesh Chodapuneedi" , "Min Chen" , "Devdeep Singh" Cc: "cloudstack" , "Sanjay Tripathi" Date: Thu, 14 Mar 2013 21:05:26 -0000 Message-ID: <20130314210526.1181.60937@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Min Chen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9892/ X-Sender: "Min Chen" References: <20130313073700.1181.2920@reviews.apache.org> In-Reply-To: <20130313073700.1181.2920@reviews.apache.org> Reply-To: "Min Chen" --===============2490097441110129398== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9892/#review17916 ----------------------------------------------------------- Ship it! Ship It! - Min Chen On March 13, 2013, 7:36 a.m., Sanjay Tripathi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9892/ > ----------------------------------------------------------- > = > (Updated March 13, 2013, 7:36 a.m.) > = > = > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and M= in Chen. > = > = > Description > ------- > = > CLOUDSTACK-1645 : Resources limit is not validated with update compute of= fering [ Instances are updated to higher CPU/Memory resources though there = are no resources available @ account/domain] = > = > = > This addresses bug CLOUDSTACK-1645. > = > = > Diffs > ----- > = > api/src/com/cloud/vm/UserVmService.java ea89eda = > api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 671= 9b8f = > server/src/com/cloud/vm/UserVmManagerImpl.java 88086ce = > = > Diff: https://reviews.apache.org/r/9892/diff/ > = > = > Testing > ------- > = > Tests: > 1. deploy an instance. > 2. stop the instance. > 3. change service offering. > a) to higher resources -- if resources are not within account resourc= e limits, CS throws resourceAllocationException else service offering succe= ssfully changed. > b) to lower resources -- success. > = > = > Thanks, > = > Sanjay Tripathi > = > --===============2490097441110129398==--