Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9931FD498 for ; Mon, 11 Mar 2013 02:29:29 +0000 (UTC) Received: (qmail 28150 invoked by uid 500); 11 Mar 2013 02:29:29 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 28117 invoked by uid 500); 11 Mar 2013 02:29:29 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 28107 invoked by uid 99); 11 Mar 2013 02:29:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Mar 2013 02:29:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A57E21C80B7; Mon, 11 Mar 2013 02:29:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2200459711792065811==" MIME-Version: 1.0 Subject: Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status From: "roxanne chang" To: "cloudstack" , "roxanne chang" Date: Mon, 11 Mar 2013 02:29:20 -0000 Message-ID: <20130311022920.2819.23325@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "roxanne chang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9818/ X-Sender: "roxanne chang" References: <20130311022855.2801.27768@reviews.apache.org> In-Reply-To: <20130311022855.2801.27768@reviews.apache.org> Reply-To: "roxanne chang" --===============2200459711792065811== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/ ----------------------------------------------------------- (Updated March 11, 2013, 2:29 a.m.) Review request for cloudstack. Description ------- Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status [https://issues.apache.org/jira/browse/CLOUDSTACK-1594] In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if= the host type is Secondary storage VM, the logic is to set secondarystorag= e host, at this time, secondarystorage host stauts should become Up. The secondary storage host always remains Alert status, because before the = secondary storage vm is deployed, the secondary storage host is created. Th= e tricky way (in the end of file AgentManagerImpl.java, function NotifiMoni= torsOfConnection) will try to disconnect secondary storage, therefore the s= econdary storage host becomes Alert status. The code should take SSVM into = consider, not only Answer reponse. File ResourceManagerImpl.java, function discoverHostsFull, in the end will = call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscove= ry, the condition _userServiceVM is not needed since its use to make second= ary storage host wait for SSVM already done in SecondarySotrageManagerImpl.= This makes why secondary storage host always remains Alert status. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594. Diffs ----- server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 = server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3c= a74a3 = server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 4= 6ac7af = Diff: https://reviews.apache.org/r/9818/diff/ Testing ------- Test 4.0.0, 4.2.0 in basic mode, works well. Thanks, roxanne chang --===============2200459711792065811==--