Return-Path: 
 <cloudstack-dev-return-26826-apmail-incubator-cloudstack-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A7681D8C9
	for <apmail-incubator-cloudstack-dev-archive@minotaur.apache.org>;
 Thu,  7 Mar 2013 09:17:32 +0000 (UTC)
Received: (qmail 29193 invoked by uid 500); 7 Mar 2013 09:17:31 -0000
Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org
Received: (qmail 28847 invoked by uid 500); 7 Mar 2013 09:17:30 -0000
Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:cloudstack-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:cloudstack-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:cloudstack-dev@incubator.apache.org>
List-Id: <cloudstack-dev.incubator.apache.org>
Reply-To: cloudstack-dev@incubator.apache.org
Delivered-To: mailing list cloudstack-dev@incubator.apache.org
Received: (qmail 28799 invoked by uid 99); 7 Mar 2013 09:17:29 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Mar 2013 09:17:29 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 05E761C7EE2;
	Thu,  7 Mar 2013 09:17:20 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============7730027842996112405=="
MIME-Version: 1.0
Subject: Re: Review Request: Feature SNMP Alerts support in CloudStack
From: "Anshul Gangwar" <anshul.gangwar@citrix.com>
To: "Rajesh Battala" <rajesh.battala@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Anshul Gangwar" <anshul.gangwar@citrix.com>
Date: Thu, 07 Mar 2013 09:17:20 -0000
Message-ID: <20130307091720.27098.90740@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Anshul Gangwar" <noreply@reviews.apache.org>
X-ReviewGroup: cloudstack
X-ReviewRequest-URL: https://reviews.apache.org/r/9587/
X-Sender: "Anshul Gangwar" <noreply@reviews.apache.org>
References: <20130306110156.27098.19297@reviews.apache.org>
In-Reply-To: <20130306110156.27098.19297@reviews.apache.org>
Reply-To: "Anshul Gangwar" <anshul.gangwar@citrix.com>

--===============7730027842996112405==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------

(Updated March 7, 2013, 9:17 a.m.)


Review request for cloudstack and Rajesh Battala.


Changes
-------

updated the patch as per comments and squashed the changes in one commit


Description
-------

This patch implements the SNMP Alerts support in CloudStack. With this feat=
ure one can configure log4j-cloud.xml to get the SNMP alerts. This feature =
uses the snmp4j library with Apache License. This feature is implemented by=
 extending log4j Appeneder. Multiple SNMP Managers can be specified. To con=
figure multiple SNMP Managers one needs to modify following portion in log4=
j-cloud.xml =

   <appender name=3D"SNMP" class=3D"org.apache.cloudstack.alert.snmp.SnmpTr=
apAppender">
      <param name=3D"Threshold" value=3D"WARN"/>
      <param name=3D"SnmpManagerIpAddresses" value=3D""/>
      <param name=3D"SnmpManagerPorts" value=3D""/>
      <param name=3D"SnmpManagerCommunities" value=3D""/>
      <layout class=3D"org.apache.cloudstack.alert.snmp.SnmpEnhancedPattern=
Layout">
         <param name=3D"PairDelimeter" value=3D"//"/>
         <param name=3D"KeyValueDelimeter" value=3D"::"/>
      </layout>
   </appender>

To specify multiple  SnmpManagerIpAddresses one has to give as follows with=
 each SNMP Manager separated by ,

   <appender name=3D"SNMP" class=3D"org.apache.cloudstack.alert.snmp.SnmpTr=
apAppender">
      <param name=3D"Threshold" value=3D"WARN"/>
      <param name=3D"SnmpManagerIpAddresses" value=3D"10.1.1.1,10.1.1.2"/>
      <param name=3D"SnmpManagerPorts" value=3D"162,162"/>
      <param name=3D"SnmpManagerCommunities" value=3D"public,public"/>
      <layout class=3D"org.apache.cloudstack.alert.snmp.SnmpEnhancedPattern=
Layout">
         <param name=3D"PairDelimeter" value=3D"//"/>
         <param name=3D"KeyValueDelimeter" value=3D"::"/>
      </layout>
   </appender>

This patch also resolves the bug https://issues.apache.org/jira/browse/CLOU=
DSTACK-960


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.


Diffs (updated)
-----

  client/pom.xml cda6ab8 =

  client/tomcatconf/log4j-cloud.xml.in 0866693 =

  core/src/com/cloud/alert/AlertManager.java a24e18c =

  plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/C=
sSnmpConstants.java PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/S=
nmpEnhancedPatternLayout.java PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/S=
nmpHelper.java PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/S=
nmpTrapAppender.java PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/S=
nmpTrapInfo.java PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/=
SnmpEnhancedPatternLayoutTest.java PRE-CREATION =

  plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/=
SnmpTrapAppenderTest.java PRE-CREATION =

  plugins/pom.xml 88f617b =

  server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8 =

  usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2 =


Diff: https://reviews.apache.org/r/9587/diff/


Testing
-------

9 unit tests have been written to test the functionality. Manually tested a=
lert generation for few alerts.


Thanks,

Anshul Gangwar


--===============7730027842996112405==--