Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 963A4D5AB for ; Mon, 4 Mar 2013 21:48:50 +0000 (UTC) Received: (qmail 95260 invoked by uid 500); 4 Mar 2013 21:48:50 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 95218 invoked by uid 500); 4 Mar 2013 21:48:50 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 95205 invoked by uid 99); 4 Mar 2013 21:48:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2013 21:48:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A21E31C7CE8; Mon, 4 Mar 2013 21:48:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2783491366655463814==" MIME-Version: 1.0 Subject: Review Request: CLOUDSTACK-1449: Fix a typo to return account-specfic user. From: "Min Chen" To: "Chip Childers" Cc: "cloudstack" , "Min Chen" Date: Mon, 04 Mar 2013 21:48:41 -0000 Message-ID: <20130304214841.27129.49153@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Min Chen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9736/ X-Sender: "Min Chen" Reply-To: "Min Chen" --===============2783491366655463814== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9736/ ----------------------------------------------------------- Review request for cloudstack and Chip Childers. Description ------- In UserAccountJoinDaoImpl.searchForAccountId(accountid), we used mismatched= condition name "accountId" (vs. "accountid") to specify account condition,= which caused returning all users for an account. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1449. Diffs ----- server/src/com/cloud/api/query/dao/UserAccountJoinDaoImpl.java 1bb3981 = Diff: https://reviews.apache.org/r/9736/diff/ Testing ------- Verified that the bug is fixed. Thanks, Min Chen --===============2783491366655463814==--