Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D672DD306 for ; Mon, 4 Mar 2013 13:19:06 +0000 (UTC) Received: (qmail 95819 invoked by uid 500); 4 Mar 2013 13:19:06 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 95664 invoked by uid 500); 4 Mar 2013 13:19:05 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 95640 invoked by uid 99); 4 Mar 2013 13:19:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2013 13:19:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 045A91C7C54; Mon, 4 Mar 2013 13:18:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6424473106588126092==" MIME-Version: 1.0 Subject: Review Request: multiple ip address per nic changes for basic zone From: "Jayapal Reddy" To: "anthony xu" , "Abhinandan Prateek" , "Murali Reddy" Cc: "cloudstack" , "Jayapal Reddy" Date: Mon, 04 Mar 2013 13:18:57 -0000 Message-ID: <20130304131857.27098.42595@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jayapal Reddy" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9730/ X-Sender: "Jayapal Reddy" Reply-To: "Jayapal Reddy" --===============6424473106588126092== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9730/ ----------------------------------------------------------- Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthon= y xu. Description ------- In this patch changes are made for the basic zone and security groups This addresses bug cloudstack-24. Diffs ----- api/src/com/cloud/agent/api/SecurityGroupRulesCmd.java affad1f = api/src/com/cloud/agent/api/to/NicTO.java aa2aa19 = api/src/com/cloud/network/security/SecurityGroupService.java c648032 = api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java 0f= 99274 = api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.ja= va cb5e085 = core/src/com/cloud/agent/api/NetworkRulesVmSecondaryIpCommand.java PRE-CR= EATION = plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResou= rceBase.java 1896b0e = scripts/vm/hypervisor/xenserver/vmops 92ed79a = server/src/com/cloud/hypervisor/HypervisorGuruBase.java efe9396 = server/src/com/cloud/network/NetworkManager.java 8b6bf9a = server/src/com/cloud/network/NetworkManagerImpl.java a575183 = server/src/com/cloud/network/NetworkModelImpl.java 0525888 = server/src/com/cloud/network/NetworkServiceImpl.java 4c61aec = server/src/com/cloud/network/dao/IPAddressDao.java 1052639 = server/src/com/cloud/network/dao/IPAddressDaoImpl.java 691e460 = server/src/com/cloud/network/guru/DirectNetworkGuru.java 46a525e = server/src/com/cloud/network/security/SecurityGroupManagerImpl.java eafe8= 8e = server/src/com/cloud/network/security/SecurityGroupManagerImpl2.java a3a0= fc3 = server/src/com/cloud/vm/UserVmManagerImpl.java 3fb5d92 = server/src/com/cloud/vm/dao/NicDao.java 794bacc = server/src/com/cloud/vm/dao/NicDaoImpl.java 4491174 = server/test/com/cloud/network/MockNetworkManagerImpl.java 8004310 = server/test/com/cloud/vpc/MockNetworkManagerImpl.java 63ef874 = Diff: https://reviews.apache.org/r/9730/diff/ Testing ------- Unit Tests done: 1. adding a secondary ip to nic 2. remove ip from nic 3. reaching public network from the VM. 4. security groups changes for the secondary ip are done. Thanks, Jayapal Reddy --===============6424473106588126092==--