cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Min Chen <min.c...@citrix.com>
Subject Re: [ACS4.1] blocker bugs
Date Sat, 02 Mar 2013 00:36:26 GMT
Thanks, Chip. Feel free to ping me if you still have issue with the patch,
then we can figure out what is the exact unit test case error.

-min

On 3/1/13 4:34 PM, "Chip Childers" <chip.childers@sungard.com> wrote:

>Perhaps a local issue. I'll retest and push if successful.  Will be
>back to a terminal in approx 45 mins or so.
>
>On Mar 1, 2013, at 7:33 PM, Min Chen <min.chen@citrix.com> wrote:
>
>> Chips,
>>
>>    I could not reproduce this. I just tried to checkout a fresh 4.1
>>branch,
>> and downloaded the patch from RB, and applied to the fresh checked out
>>4.1
>> branch. I then ran "mvn clean install", everything is successful.
>>
>>    -min
>>
>> On 3/1/13 4:18 PM, "Chip Childers" <chip.childers@sungard.com> wrote:
>>
>>> See my comment in the review - I get unit test failures after applying.
>>>
>>> On Fri, Mar 01, 2013 at 03:05:37PM -0800, Min Chen wrote:
>>>> Chips,
>>>>    A patch review request for the blocker defect 1470 has been
>>>>submitted:
>>>> https://reviews.apache.org/r/9710/. Please review and submit at your
>>>> earliest convenience to unblock QA.
>>>>    Thanks.
>>>>
>>>>    -min
>>>>
>>>>
>>>> On 3/1/13 3:17 AM, "Rohit Yadav" <bhaisaab@apache.org> wrote:
>>>>
>>>>> For 1470, deployvm does not work, I used the same logic used in
>>>>>create
>>>>> vm from scratch and it works for me, see:
>>>>>
>>>>> diff --git
>>>>
>>>>> 
>>>>>a/engine/orchestration/src/org/apache/cloudstack/platform/orchestratio
>>>>>n/
>>>>> Cl
>>>>> oudOrchestrator.java
>>>>
>>>>> 
>>>>>b/engine/orchestration/src/org/apache/cloudstack/platform/orchestratio
>>>>>n/
>>>>> Cl
>>>>> oudOrches
>>>>> index 34673f2..cae25ac 100755
>>>>> ---
>>>>
>>>>> 
>>>>>a/engine/orchestration/src/org/apache/cloudstack/platform/orchestratio
>>>>>n/
>>>>> Cl
>>>>> oudOrchestrator.java
>>>>> +++
>>>>
>>>>> 
>>>>>b/engine/orchestration/src/org/apache/cloudstack/platform/orchestratio
>>>>>n/
>>>>> Cl
>>>>> oudOrchestrator.java
>>>>> @@ -170,7 +170,15 @@ public class CloudOrchestrator implements
>>>>> OrchestrationService {
>>>>>            }
>>>>>        }
>>>>>
>>>>> -       VirtualMachineEntityImpl vmEntity =
>>>>> ComponentContext.inject(VirtualMachineEntityImpl.class);
>>>>> +       //VirtualMachineEntityImpl vmEntity =
>>>>> ComponentContext.inject(VirtualMachineEntityImpl.class);
>>>>> +        VirtualMachineEntityImpl vmEntity = null;
>>>>> +        try {
>>>>> +            vmEntity = VirtualMachineEntityImpl.class.newInstance();
>>>>> +            vmEntity = ComponentContext.inject(vmEntity);
>>>>> +
>>>>> +        } catch (Exception e) {
>>>>> +            // add error handling here
>>>>> +        }
>>>>>       vmEntity.init(id, owner, hostName, displayName, cpu, speed,
>>>>> memory, computeTags, rootDiskTags, new
>>>>> ArrayList<String>(networkNicMap.keySet()));
>>>>>
>>>>> Kelven, Chip pl. review it and commit/apply on master/4.1 as needed.
>>>>>
>>>>> Regards.
>>>>>
>>>>> On Fri, Mar 1, 2013 at 4:36 PM, Ram Ganesh <Ram.Ganesh@citrix.com>
>>>> wrote:
>>>>>> Hi Abhi,
>>>>>>
>>>>>> 1469 is assigned to Rajesh
>>>>>>
>>>>>> Thanks,
>>>>>> RamG
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Abhinandan Prateek [mailto:Abhinandan.Prateek@citrix.com]
>>>>>> Sent: 01 March 2013 16:22
>>>>>> To: cloudstack dev
>>>>>> Subject: [ACS4.1] blocker bugs
>>>>>>
>>>>>> Can someone from community pick any of these bugs ? These are
>>>> blocking
>>>>>> QA.
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/CLOUDSTACK-1470
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/CLOUDSTACK-1469
>>>>>>
>>>>>> -abhi
>>
>>


Mime
View raw message