cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Noah Slater <nsla...@apache.org>
Subject Re: [DISCUSS] Commit email notifications
Date Tue, 26 Mar 2013 17:39:44 GMT
Let the good times roll! Thanks Paul.


On 26 March 2013 17:36, Paul Davis <paul.joseph.davis@gmail.com> wrote:

> Done.
>
> On Tue, Mar 26, 2013 at 11:43 AM, Noah Slater <nslater@apache.org> wrote:
> > Here we go Paul: https://issues.apache.org/jira/browse/INFRA-6063
> >
> >
> > On 21 March 2013 19:19, Paul Davis <paul.joseph.davis@gmail.com> wrote:
> >>
> >> I added some basic documentation on the specification and the
> >> available variables for use here:
> >>
> >> https://git-wip-us.apache.org/docs/commit-emails.html
> >>
> >> If you guys decide on a new format throw it in a JIRA ticket and I'll
> >> make the switch.
> >>
> >> On Thu, Mar 21, 2013 at 8:37 AM, Noah Slater <nslater@apache.org>
> wrote:
> >> > Hey CloudStack devs,
> >> >
> >> > A bit of potential cross pollination here...
> >> >
> >> > I take it you've all noticed the
> >> > screen-full-of-emails-generated-by-a-Git-push thing we have going on?
> >> > Well,
> >> > Paul Davis has figured out a way to get all those commits wrapped up
> >> > into a
> >> > single thread in mail clients that support threading. (See the
> forwarded
> >> > message.)
> >> >
> >> > Is this something we're interested in switching to?
> >> >
> >> > Thanks,
> >> >
> >> >
> >> > ---------- Forwarded message ----------
> >> > From: Paul Davis <paul.joseph.davis@gmail.com>
> >> > Date: 20 March 2013 09:13
> >> > Subject: Commit email notifications
> >> > To: dev@couchdb.apache.org
> >> >
> >> >
> >> > First off, apologies for the commit spam. But hopefully I've managed
> >> > to find a decent combination of useful information and helpful
> >> > threading for most email clients.
> >> >
> >> > I got caught in the wind playing with email headers trying to set the
> >> > Message-Id and In-Reply-To/References headers to get threading to work
> >> > for the git email notifications. Then I remembered that GMail
> >> > basically ignores those. So I've gone and also changed the subject
> >> > formatting so that GMail does play nicely with threads.
> >> >
> >> > Basically, I've switched between these two email styles for commit
> >> > notifications:
> >> >
> >> > Old Style:
> >> >
> >> >     [1/4] git commit: test commit 1/3
> >> >
> >> > New Style:
> >> >
> >> >     [1/4] git commit: updated refs/heads/testing-email-notifications
> to
> >> > 51293df
> >> >
> >> > The first one has the benefit of showing what the actual commit was
> >> > about (this same information is repeated in the body) but the downside
> >> > is that GMail does terrible thing in conversation view with these. I
> >> > added a few things to the subject formatting and then set the format
> >> > CouchDB uses to the style shown. This style has the benefit that each
> >> > "push" to the repo should generate unique GMail conversations for each
> >> > branch updated and also gives us a bit of a log on individual updates
> >> > (a more thorough log is available via a URL I'm too lazy to lookup at
> >> > 4am).
> >> >
> >> > One of the major thorns I've been chewing on for awhile is when we
> >> > make an identical commit to more than one version branch and push all
> >> > of those updated branches in one go. The old version would group them
> >> > into a single GMail conversation which is a bit misleading and
> >> > sometimes hard to pick apart. The new format should avoid that but at
> >> > the loss of reading the "git log --oneline" history type log (that's
> >> > really out of order so not totally useful).
> >> >
> >> > So if I'm crazy and people really like the "single push fills your
> >> > inbox" approach let me know and I'll revert it and be more formal
> >> > about the change. Though hopefully this new behavior is a net positive
> >> > for everyone involved as my 4am brain seems to think is reasonable
> >> > which means I've probably pissed off a whole bunch of people.
> >> >
> >> >
> >> >
> >> > --
> >> > NS
> >
> >
> >
> >
> > --
> > NS
>



-- 
NS

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message