cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Huang <Alex.Hu...@citrix.com>
Subject RE: Action Events are not logged due to spring changes
Date Thu, 14 Mar 2013 13:43:23 GMT
This is a big bug.  Have you filed jira issue?

--Alex

> -----Original Message-----
> From: Kishan Kavala [mailto:Kishan.Kavala@citrix.com]
> Sent: Thursday, March 14, 2013 5:44 AM
> To: 'cloudstack-dev@incubator.apache.org'
> Cc: Kelven Yang
> Subject: Action Events are not logged due to spring changes
> 
> CS Events are triggered by ActionEvent annotation. ActionEvent annotations
> are in manager Impl. Spring proxies the interface and not the implementing
> class.
> Since there are no annotations at the interface level, needToIntercept
> method in ActionEventInterceptor always returns false.
> 
> TransactionContextBuilder intercepts by getting the implementing class and
> going through all the methods in it to match the method name. Going
> through all the methods every time may not be efficient.
> There could be multiple methods with same name, so matching by method
> name could be error prone as well.
> 
> This can be solved by moving all annotations to respective interfaces. But this
> would mean, code changes at lot of places. Is there a better solution solve
> this?


Mime
View raw message