cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.
Date Thu, 14 Mar 2013 18:59:32 GMT
Hiroaki

Can you add Chiradeep and Hugo as reviewers

> -----Original Message-----
> From: Hiroaki Kawai [mailto:noreply@reviews.apache.org] On Behalf Of
> Hiroaki Kawai
> Sent: Tuesday, March 12, 2013 12:24 AM
> To: cloudstack; Hiroaki Kawai
> Subject: Review Request: (CLOUDSTACK-1638) Network plugins won't be
> notified VM migration.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9871/
> -----------------------------------------------------------
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> The location of the virtual machine is provided by DeployDestination, which
> will be passed in NetworkGuru#reserve and NetworkElement#prepare.
> 
> During the virtual machine migration, it actually changes DeployDestination
> and it looks like that it will tell that event to network components as it has
> NetworkManager#prepareNicForMigration. The problem is that althogh the
> interface has that method, NetworkManagerImpl does not tell the
> DeployDestination changes to network components.
> 
> So IMHO, we need to add calls of NetworkGuru#reserve and
> NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration
> . And then, we also need to add calls NetworkGuru#release and
> NetworkElement#release after the migration, otherwise the network
> resources that plugin reserved will be kept even when the vm leaves off.
> 
> Created a first minimum patch to show the concept.
> 
> 
> This addresses bug CLOUDSTACK-1638.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkManager.java 8b6bf9a
>   server/src/com/cloud/network/NetworkManagerImpl.java ba5ab5d
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 0aeef0e
> 
> Diff: https://reviews.apache.org/r/9871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hiroaki Kawai

Mime
View raw message