cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request: CLOUDSTACK-356 Snapshot errors with multiple secondary storage in one zone.
Date Thu, 14 Mar 2013 18:51:34 GMT
Please commit the patch

> -----Original Message-----
> From: anthony xu [mailto:noreply@reviews.apache.org] On Behalf Of
> anthony xu
> Sent: Thursday, March 14, 2013 11:49 AM
> To: Anthony Xu
> Cc: cloudstack; Deepti Dohare
> Subject: Re: Review Request: CLOUDSTACK-356 Snapshot errors with
> multiple secondary storage in one zone.
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7594/#review17902
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Ship It!
> 
> - anthony xu
> 
> 
> On Feb. 27, 2013, 9:29 a.m., deepti dohare wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7594/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 27, 2013, 9:29 a.m.)
> >
> >
> > Review request for cloudstack and anthony xu.
> >
> >
> > Description
> > -------
> >
> > Fixed CLOUDSTACK-356
> > The issue is happening because of the multiple secondary storages, the
> secondary storage which is used first is getting mounted on the host resulting
> in failure of other snapshot using different secondary storage as it is not
> getting mounted on the host.
> > For eg:
> > 1. When first incremental snapshot (eg Ssec1-1) is taken, secondary storage
> (sec1) is mounted on local path “/var/run/sr-mount/ on the host.
> > 2. Second incremental snapshot (Ssec1-2) is created, to get the parent vhd,
> the secondary storage is mounted at mount path
> “/var/run/cloud_mount/dc_id/snapshots”.
> > 3. If other snapshot (for different volume) is created on different
> secondary storage (sec2), sec2 is not getting mounted on
> "/var/run/cloud_mount/dc_id/snapshots" path.
> >
> > The fix is to mount other secondary storages as well on the host. The local
> mount path in vmopsSnapshot.py is modified, instead of mounting on
> “/var/run/cloud_mount/dc_id/snapshots”,
> “/var/run/cloud_mount/dc_id/snapshots/secHostid” mount path is used.
> >
> >
> > This addresses bug CLOUDSTACK-356.
> >
> >
> > Diffs
> > -----
> >
> >   api/src/com/cloud/agent/api/BackupSnapshotCommand.java a0ac8d7
> >
> api/test/org/apache/cloudstack/api/agent/test/BackupSnapshotAnswerTest
> .java ede86e9
> >
> api/test/org/apache/cloudstack/api/agent/test/BackupSnapshotCommandT
> est.java 7100497
> >
> engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMo
> tionStrategy.java cfd9f40
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixReso
> urceBase.java 4a89806
> >   scripts/vm/hypervisor/xenserver/vmopsSnapshot 6fb1b18
> >   scripts/vm/hypervisor/xenserver/xcposs/vmopsSnapshot f7b2e0e
> >
> > Diff: https://reviews.apache.org/r/7594/diff/
> >
> >
> > Testing
> > -------
> >
> > Tested for following cases:
> > 1. Snapshot Creation:
> > Host 1 has a vm i-1, volume ROOT-1 DATA-1, Host 2 has a vm i-2, volume
> ROOT-2 DATA-2, Taken recurring snapshot for 4 volumes.
> > Verified: multiple secondary storages are getting mounted on host.
> > Snapshots creation successful 2. Template Creation:
> > Verified: templates successfully created from the above snapshots 3.
> > Volume creation:
> > Verified: volumes successfully created from the above snapshots 4. VM
> > Migration Migrate i-1  from Host-1 to Host-2.
> > Verified: Secondary mount point successfully created on Host-2.
> >
> >
> >
> > Thanks,
> >
> > deepti dohare
> >
> >

Mime
View raw message