cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request: Mulitiple ip address per nic support for advacned shared networks
Date Fri, 29 Mar 2013 10:59:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10040/#review18503
-----------------------------------------------------------



server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10040/#comment38794>

    this check not required



server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10040/#comment38795>

    Same here.this check not required


- Murali Reddy


On March 21, 2013, 3:58 a.m., Jayapal Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10040/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 3:58 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
> 
> 
> Description
> -------
> 
> Changes added for supporting multiple ip address per nic for shared networks
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkServiceImpl.java 8303b0b 
> 
> Diff: https://reviews.apache.org/r/10040/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested adding and removing the ip for nic using the APIs
> 
> 
> Thanks,
> 
> Jayapal Reddy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message