cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: CS 1773 seems to break build and networking.
Date Wed, 27 Mar 2013 13:31:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10150/#review18420
-----------------------------------------------------------

Ship it!


This appears to have already been applied by Prasanna (thanks Prasanna!) at commit-sh 8a358980b77febd8336549ac9ca1d79ad36afc65

- Chip Childers


On March 27, 2013, 9:21 a.m., Funs Kessen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10150/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, 9:21 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> 4.1 compiling and network seem to have been broken by disabling baremetal in the code.
The fix comments out the UCS bit so the client GUI doesn't break the build. The network service
implementation breaks the deployment of VMs as BareMetal is still called there but it's not
in the code anymore:
> 2013-03-26 12:46:59,302 WARN  [cloud.network.NetworkServiceImpl] (1572481896@qtp-789857310-7:null)
Exception: 
> com.cloud.exception.InvalidParameterValueException: Invalid Network Service Provider=BaremetalDhcpProvider
>         at com.cloud.network.NetworkServiceImpl.addProviderToPhysicalNetwork(NetworkServiceImpl.java:2300)
>         at com.cloud.network.NetworkServiceImpl.addDefaultBaremetalProvidersToPhysicalNetwork(NetworkServiceImpl.java:2789)
>         at com.cloud.network.NetworkServiceImpl.createPhysicalNetwork(NetworkServiceImpl.java:1949)
> 
> 
> This addresses bug CS-1773.
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 33a2274 
>   plugins/network-elements/dns-notifier/resources/components-example.xml 36441bd 
>   server/src/com/cloud/network/NetworkServiceImpl.java 0cd3ebe 
> 
> Diff: https://reviews.apache.org/r/10150/diff/
> 
> 
> Testing
> -------
> 
> Took a fresh checkout, did the changes, compiled, ran cloudmonkey and presto I had a
couple of VMs
> 
> 
> Thanks,
> 
> Funs Kessen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message