cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM
Date Tue, 26 Mar 2013 08:22:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review18386
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment38589>

    Can you put some log message here, since restore is already completed till this point
and only password reset is left that user can do by resetting the password afterwards if it
fails here.


- Harikrishna Patnala


On March 22, 2013, 4:42 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 4:42 a.m.)
> 
> 
> Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message