cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: Bugfix CLOUDSTACK-1761: Fixed KVM plugin to return available storage which client is expecting instead of used
Date Fri, 22 Mar 2013 15:33:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10069/#review18271
-----------------------------------------------------------


Commit ff6177d119bb49e90fa325ca51f4eec217bae915 in branch refs/heads/master from Marcus Sorensen
<marcus@betterservers.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ff6177d ]

CLOUDSTACK-1761 - Available local storage disk capacity incorrectly reported in
     KVM to manager. This adds collection of available storage to KVM, not
     just used.

Bugfix-for: 4.0.2, 4.1, master
Submitted-by: Ted Smith <darnoth@gmail.com>
Signed-off-by: Marcus Sorensen <marcus@betterservers.com> 1363966235 -0600


- ASF Subversion and Git Services


On March 22, 2013, 3:07 p.m., Ted Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10069/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 3:07 p.m.)
> 
> 
> Review request for cloudstack and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1761: Fixed KVM plugin to return available storage which client is
expecting instead of used disk space. This caused CloudStack to mistakenly believe that there
was not enough free disk space and it was unable to provision new instances.
> 
> 
> This addresses bug CLOUDSTACK-1761.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
8ee3ea4 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePool.java 5437e7c

>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
d5e6ad6 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStoragePool.java
32f8ce9 
> 
> Diff: https://reviews.apache.org/r/10069/diff/
> 
> 
> Testing
> -------
> 
> Built on Ubuntu 12.04. Tested on Ubuntu 12.04 client. Verified availableBytes was correctly
returned as the amount of available disk space and not the amounted of allocated disk space.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:08.767s
> [INFO] Finished at: Thu Mar 21 16:37:12 PDT 2013
> [INFO] Final Memory: 53M/1071M
> [INFO] ------------------------------------------------------------------------
> 
> 2013-03-21 16:45:24,714 DEBUG [cloud.agent.Agent] (Agent-Handler-1:null) Sending Startup:
Seq -1-0:  { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags: 1, [{"StartupRoutingCommand":{"cpus":32,"speed":2701,"memory":135144730624,"dom0MinMemory":805306368,"poolSync":false,"vms":{},"caps":"hvm,snapshot","pool":"/root","hypervisorType":"KVM","hostDetails":{"com.cloud.network.Networks.RouterPrivateIpStrategy":"HostLocal","Host.OS":"Ubuntu","Host.OS.Kernel.Version":"3.2.0-38-generic","Host.OS.Version":"12.04"},"type":"Routing","dataCenter":"1","pod":"1","cluster":"14","guid":"61430069-ba1d-3cac-ab97-6b37b5d16263-LibvirtComputingResource","name":"somename018","version":"4.2.0-SNAPSHOT","publicIpAddress":"10.81.96.68","publicNetmask":"255.255.255.0","publicMacAddress":"78:45:c4:fb:26:76","privateIpAddress":"10.81.96.68","privateMacAddress":"78:45:c4:fb:26:76","privateNetmask":"255.255.255.0","storageIpAddress":"10.81.96.68","storageNetmask":"255.255.255.0","storageMacAddress":"78:45:c4:fb:26:76","resourceName":"LibvirtComputingResource","gatewayIpAddress":"10.81.96.1","wait":0}},{"StartupStorageCommand":{"totalSize":0,"poolInfo":{"uuid":"a7dff188-aebd-4702-aecf-b33f781222a8","host":"10.81.96.68","localPath":"/var/lib/libvirt/images/","hostPath":"/var/lib/libvirt/images/","poolType":"Filesystem","capacityBytes":4956273893376,"availableBytes":4954406244352},"resourceType":"STORAGE_POOL","hostDetails":{},"type":"Storage","dataCenter":"1","pod":"1","guid":"61430069-ba1d-3cac-ab97-6b37b5d16263-LibvirtComputingResource","name":"computestage018","version":"4.2.0-SNAPSHOT","resourceName":"LibvirtComputingResource","wait":0}}]
}
> 2013-03-21 16:45:24,714 DEBUG [cloud.agent.Agent] (Agent-Handler-1:null) Startup task
created
> 
> 
> Thanks,
> 
> Ted Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message