cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Soundararajan" <pradeep.soundarara...@citrix.com>
Subject Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
Date Fri, 22 Mar 2013 10:21:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/
-----------------------------------------------------------

(Updated March 22, 2013, 10:21 a.m.)


Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang, Wido
den Hollander, and Noa Resare.


Changes
-------

Updated the patch. It is for 4.1 only, let me create a patch for master.


Description
-------

BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware

Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.

Signed-off-by: Pradeep <pradeep.soundararajan@citrix.com>
--------------------------------------------------------------------------------------

Now package.sh will act based on the below usage i.e. with or without arguments:

 ./package.sh -h

usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]

The commonly used Arguments are:
oss|OSS         To package OSS specific
nonoss|NONOSS   To package NONOSS specific

Examples: ./package.sh -p|--pack oss|OSS
          ./package.sh -p|--pack nonoss|NONOSS
          ./package.sh (Default OSS)

---------------------------------------------------------------------------------------


Diffs (updated)
-----

  packaging/centos63/cloud.spec a7a6927 
  packaging/centos63/package.sh 2515ecb 

Diff: https://reviews.apache.org/r/9900/diff/


Testing
-------

I have tested these changes. They are working well. Please review and submit it if you are
fine.

In future, we can even change the mvn commands as per our need from cloud.spec.


Thanks,

Pradeep Soundararajan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message