cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Date Wed, 20 Mar 2013 00:36:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/#review18125
-----------------------------------------------------------

Ship it!


Committed.  Thanks for the patch!

- Chip Childers


On March 14, 2013, 8:41 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9923/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 8:41 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Description
> -------
> 
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to
remove gateway ip from this list.
> 
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists
which do not include the first IP of the network (like 192.168.0.1). 
> We need too add the first IP into the returned Ip list, because it can be used for VM
if it is not the gateway IP (for example, VPC networks).
> 
> 
> This addresses bug CLOUDSTACK-1668.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkManagerImpl.java b33c52b 
>   utils/src/com/cloud/utils/net/NetUtils.java 1341338 
> 
> Diff: https://reviews.apache.org/r/9923/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok in VPC tier and non-VPC network.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message