cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier on master/4.1
Date Wed, 20 Mar 2013 00:35:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10022/#review18123
-----------------------------------------------------------


Commit af0723e9c9259619c2cb5d77396e2297f1273a5e in branch refs/heads/4.0 from Chip Childers
<chip.childers@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=af0723e ]

CLOUDSTACK-1668: Fix IP conflict in VPC tier

Currently, allPossibleIps return the Ip lists which include the gateway,
so we need to remove gateway ip from this list.

Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr
return the Ip lists which do not include the first IP of the network
(like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can
be used for VM if it is not the gateway IP (for example, VPC networks).

Signed-off-by: Chip Childers <chip.childers@gmail.com>


- ASF Subversion and Git Services


On March 19, 2013, 8:25 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10022/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 8:25 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to
remove gateway ip from this list.
> 
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists
which do not include the first IP of the network (like 192.168.0.1). 
> We need too add the first IP into the returned Ip list, because it can be used for VM
if it is not the gateway IP (for example, VPC networks).
> 
> The corresponding patch for 4.0.1 has been posted on https://reviews.apache.org/r/9923/
> 
> 
> This addresses bug CLOUDSTACK-1668.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkModelImpl.java 779b9f2 
>   server/src/com/cloud/network/NetworkServiceImpl.java 52e81e5 
>   utils/src/com/cloud/utils/net/NetUtils.java dd40a33 
> 
> Diff: https://reviews.apache.org/r/10022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message