cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vijay Venkatachalam" <vijay.venkatacha...@citrix.com>
Subject Re: Review Request: Fix for CLOUDSTACK-1537 - Restart network with clean up set to true causes Autoscaled LB rule to get mangled and unusable
Date Tue, 19 Mar 2013 17:18:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10017/
-----------------------------------------------------------

(Updated March 19, 2013, 5:18 p.m.)


Review request for cloudstack, Devdeep Singh, Murali Reddy, Chiradeep Vittal, and Ram Ganesh.


Changes
-------

Adding Murali and Chiradeep as reviewers since it touches NetworkManagerImpl as well!


Description
-------

Bug Title: Restart network with clean up set to true causes Autoscaled LB rule to get mangled
and unusable 

AutoScale LB information was not packaged for restart of network case to Resource Layer. This
caused the undesired outcome and it is fixed now. NetWorkManagerImpl was doing the cleanup
of the LBRules during restart, after the fix; NetWorkManagerImpl  will only act as a trigger,
the actual job related to LB Rules (for ex. remove/revoke) will be handled by LBRules Manager
(which should have been the actual implementation, so moved code around). 

Also, NetScaler resource is simplified to handle create/enable/disable/restart in one code
path. 


This addresses bug CLOUDSTACK-1537.


Diffs
-----

  api/src/com/cloud/network/lb/LoadBalancingRule.java fb1d988 
  plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
abea464 
  server/src/com/cloud/network/NetworkManagerImpl.java f6e32fb 
  server/src/com/cloud/network/lb/LoadBalancingRulesManager.java 9d7d22f 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 531a428 

Diff: https://reviews.apache.org/r/10017/diff/


Testing
-------


1. Create/Delete/ScaleUp/ScaleDown/Enable/Disable of AutoScale LB Rule
2. Restart of Network with AutoScale LB Rule - Cleanup == false
3. Restart of Network with AutoScale LB Rule - Cleanup == true
4. Create/Delete of Non-AutoScale LB Rule


Thanks,

Vijay Venkatachalam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message