cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <>
Subject Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.
Date Fri, 15 Mar 2013 06:51:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 15, 2013, 6:51 a.m.)

Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.


add Chiradeep and Hugo as reviewers


The location of the virtual machine is provided by DeployDestination, which will be passed
in NetworkGuru#reserve and NetworkElement#prepare. 

During the virtual machine migration, it actually changes DeployDestination and it looks like
that it will tell that event to network components as it has NetworkManager#prepareNicForMigration.
The problem is that althogh the interface has that method, NetworkManagerImpl does not tell
the DeployDestination changes to network components. 

So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration
. And then, we also need to add calls NetworkGuru#release and NetworkElement#release after
the migration, otherwise the network resources that plugin reserved will be kept even when
the vm leaves off.

Created a first minimum patch to show the concept.

This addresses bug CLOUDSTACK-1638.


  server/src/com/cloud/network/ 8b6bf9a 
  server/src/com/cloud/network/ ba5ab5d 
  server/src/com/cloud/vm/ 0aeef0e 




Hiroaki Kawai

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message