cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Soundararajan" <pradeep.soundarara...@citrix.com>
Subject Re: Review Request: Proposal & BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
Date Fri, 15 Mar 2013 06:00:49 GMT


> On March 15, 2013, 12:49 a.m., Chip Childers wrote:
> > I'd like Wido, David, Hugo or Noa to review this before it's committed to 4.1 please.
> > 
> > Has this been tested on master?

Chip, this patch is not related to any branch specific. These changes are common for packaging.


- Pradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9900/#review17932
-----------------------------------------------------------


On March 13, 2013, 12:46 p.m., Pradeep Soundararajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9900/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 12:46 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, Alex Huang,
Wido den Hollander, and Noa Resare.
> 
> 
> Description
> -------
> 
> BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware
> 
> Proposing to modify package.sh script. Package as per OSS or NONOSS arguments.
> 
> Signed-off-by: Pradeep <pradeep.soundararajan@citrix.com>
> --------------------------------------------------------------------------------------
> 
> Now package.sh will act based on the below usage i.e. with or without arguments:
> 
>  ./package.sh -h
> 
> usage: ./package.sh [-p|--pack] [-h|--help] [ARGS]
> 
> The commonly used Arguments are:
> oss|OSS         To package OSS specific
> nonoss|NONOSS   To package NONOSS specific
> 
> Examples: ./package.sh -p|--pack oss|OSS
>           ./package.sh -p|--pack nonoss|NONOSS
>           ./package.sh (Default OSS)
> 
> ---------------------------------------------------------------------------------------
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b 
>   packaging/centos63/package.sh 2515ecba11fee3ea8dd5f85884861585392a26cd 
> 
> Diff: https://reviews.apache.org/r/9900/diff/
> 
> 
> Testing
> -------
> 
> I have tested these changes. They are working well. Please review and submit it if you
are fine.
> 
> In future, we can even change the mvn commands as per our need from cloud.spec.
> 
> 
> Thanks,
> 
> Pradeep Soundararajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message