cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers" <chip.child...@sungard.com>
Subject Re: Review Request: CLOUDSTACK-1684:api.throttling.enabled configuration setting should be set to "false" in Config.java
Date Fri, 15 Mar 2013 01:17:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9924/#review17935
-----------------------------------------------------------

Ship it!


Applied to 4.1 and master.

- Chip Childers


On March 15, 2013, 1:12 a.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9924/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 1:12 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The default setting for api throttling should be "disabled", so in global config, api.throttling.enabled
should have default value "false" instead of "true". Currently it is not reported as a bug
by QA because we have put "false" in schema upgrade script, but it is better to be consistent.

> 
> 
> This addresses bug CLOUDSTACK-1684.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/Config.java 5313129 
> 
> Diff: https://reviews.apache.org/r/9924/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Min Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message