cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Animesh Chaturvedi" <Animesh.Chaturv...@citrix.com>
Subject Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
Date Thu, 14 Mar 2013 01:57:13 GMT


> On None, roxanne chang wrote:
> > Ship It!

Reviwer should mark the patch as "Ship it" not the submitter. Please refere to Review Board
guidelines https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines.
Also add Edison Su as reviewer


- Animesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review17603
-----------------------------------------------------------


On March 11, 2013, 2:29 a.m., roxanne chang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 2:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host
type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage
host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the secondary
storage vm is deployed, the secondary storage host is created. The tricky way (in the end
of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect
secondary storage, therefore the secondary storage host becomes Alert status. The code should
take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery,
in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed
since its use to make secondary storage host wait for SSVM already done in SecondarySotrageManagerImpl.
This makes why secondary storage host always remains Alert status.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58 
>   server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java 3ca74a3 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 46ac7af 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> -------
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message