cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Min Chen" <min.c...@citrix.com>
Subject Review Request: CLOUDSTACK-1656:NicResponses in a UserVmResponse are not preseving the natural order.
Date Wed, 13 Mar 2013 01:08:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9890/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

For a UserVm with multiple Nics, listVMCmd will return this VM with NicResponses in reverse
order, not ordered by device_id of Nic table. This patch fixed this issue by using LinkedHashSet
instead of HashSet to preserve insertion order.


This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1656.


Diffs
-----

  api/src/org/apache/cloudstack/api/response/DomainRouterResponse.java 274e7a5 
  api/src/org/apache/cloudstack/api/response/SecurityGroupResponse.java 1130ec0 
  api/src/org/apache/cloudstack/api/response/UserVmResponse.java cb2113e 
  api/src/org/apache/cloudstack/api/response/VolumeResponse.java b10da0c 

Diff: https://reviews.apache.org/r/9890/diff/


Testing
-------

Tested locally.


Thanks,

Min Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message