cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-874 Ability to delete Events and Alerts
Date Wed, 06 Mar 2013 18:16:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9753/
-----------------------------------------------------------

(Updated March 6, 2013, 6:16 p.m.)


Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen.


Changes
-------

Added unit tests and resolved conflicts with the latest code.


Description
-------

This feature will provide the functionality to delete or archive
the Alerts/Events.
Delete or archive alerts APIs are available only for root-admin,
delete or archive events are available for regular users.

Functional Spec:https://cwiki.apache.org/confluence/display/CLOUDSTACK/Ability+to+delete+or+archive+Events+and+Alerts


This addresses bugs Ability, Alerts, CLOUDSTACK-874, Events, and, delete, and to.


Diffs (updated)
-----

  api/src/com/cloud/alert/Alert.java 050f97f 
  api/src/com/cloud/event/Event.java 1a61636 
  api/src/com/cloud/server/ManagementService.java 1736da3 
  api/src/org/apache/cloudstack/api/ApiConstants.java 1b544fd 
  api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java PRE-CREATION 
  client/tomcatconf/commands.properties.in dd0c3f8 
  core/src/com/cloud/alert/AlertVO.java f6089d6 
  core/src/com/cloud/event/EventVO.java ac46f24 
  core/src/com/cloud/event/dao/EventDao.java bfcb818 
  core/src/com/cloud/event/dao/EventDaoImpl.java 44fbb03 
  server/src/com/cloud/alert/dao/AlertDao.java eb1faa5 
  server/src/com/cloud/alert/dao/AlertDaoImpl.java 2f3be88 
  server/src/com/cloud/api/ApiDispatcher.java 764b3ae 
  server/src/com/cloud/api/query/QueryManagerImpl.java 8d8663a 
  server/src/com/cloud/api/query/vo/EventJoinVO.java f29a942 
  server/src/com/cloud/configuration/Config.java 418f97d 
  server/src/com/cloud/server/ManagementServerImpl.java 3c615e1 
  server/test/com/cloud/alert/AlertControlsUnitTest.java PRE-CREATION 
  server/test/com/cloud/event/EventControlsUnitTest.java PRE-CREATION 
  setup/db/db/schema-410to420.sql f3112a1 

Diff: https://reviews.apache.org/r/9753/diff/


Testing
-------

Tested the new API archiveAlerts, deleteAlerts, archiveEvents, deleteEvents with all the possible
combinations of parameters as input on my local CloudStack setup.


Thanks,

Sanjay Tripathi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message