cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Battala" <rajesh.batt...@citrix.com>
Subject Re: Review Request: Remove invalid use of library internal class found in vmware-base
Date Wed, 06 Mar 2013 06:07:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/#review17460
-----------------------------------------------------------


I was trying to apply this patch got below errors.


vmwareissue.patch:46: trailing whitespace.
                    new CookieOrigin(urlUrl.getHost(), urlUrl.getPort(),
vmwareissue.patch:53: trailing whitespace.

vmwareissue.patch:89: tab in indent.
                String cookie = _vimClient.getServiceCookie();
vmwareissue.patch:104: tab in indent.
                String cookie = _vimClient.getServiceCookie();
vmwareissue.patch:113: tab in indent.
            conn.addRequestProperty("Cookie", cookie);
warning: 5 lines add whitespace errors.


- Rajesh Battala


On March 6, 2013, 5:46 a.m., Hiroaki Kawai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9768/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 5:46 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar,
but it must not do so, because it is an library internal class.
> 
> 
> This addresses bug CLOUDSTACK-1529.
> 
> 
> Diffs
> -----
> 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 
> 
> Diff: https://reviews.apache.org/r/9768/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message