cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjay Tripathi <sanjay.tripa...@citrix.com>
Subject RE: Review Request: CLOUDSTACK-874 Ability to delete Events and Alerts
Date Wed, 06 Mar 2013 05:16:42 GMT
Hari,


> -----Original Message-----
> From: Hari Kannan
> Sent: Wednesday, March 06, 2013 1:15 AM
> To: cloudstack-dev@incubator.apache.org; Sanjay Tripathi; Sateesh
> Chodapuneedi; Min Chen; Devdeep Singh
> Subject: RE: Review Request: CLOUDSTACK-874 Ability to delete Events and
> Alerts
> 
> Hello Sanjay
> 
> Can you please let me know what happens during an upgrade? Specifically,
> wanted to confirm that the default setting of the global alert.purge.delay is
> set to do-not-delete, which is the current behavior?

In case of upgrade, CS creates a new column "archived" of Boolean type in alert and event
tables and fill the column with default value 0 i.e. false.
Yes the default setting of global alert.purge.delay is set to do-no-delete.

> 
> Also, is there an equivalent global/setting for events?

We already have "event.purge.delay" as equivalent global setting for events,
which is by default set to 15 days i.e events older than 15 days will be purged.

> 
> Hari
> 
> -----Original Message-----
> From: Sanjay Tripathi [mailto:noreply@reviews.apache.org] On Behalf Of
> Sanjay Tripathi
> Sent: Tuesday, March 5, 2013 11:07 AM
> To: Sateesh Chodapuneedi; Min Chen; Devdeep Singh
> Cc: cloudstack; Sanjay Tripathi
> Subject: Review Request: CLOUDSTACK-874 Ability to delete Events and
> Alerts
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9753/
> -----------------------------------------------------------
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and
> Min Chen.
> 
> 
> Description
> -------
> 
> This feature will provide the functionality to delete or archive the
> Alerts/Events.
> Delete or archive alerts APIs are available only for root-admin, delete or
> archive events are available for regular users.
> 
> Functional
> Spec:https://cwiki.apache.org/confluence/display/CLOUDSTACK/Feature+-
> +Ability+to+delete+Events+and+Alerts
> 
> 
> This addresses bugs Ability, Alerts, CLOUDSTACK-874, Events, and, delete,
> and to.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/alert/Alert.java 050f97f
>   api/src/com/cloud/event/Event.java 1a61636
>   api/src/com/cloud/server/ManagementService.java 1736da3
>   api/src/org/apache/cloudstack/api/ApiConstants.java 1b544fd
> 
> api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlerts
> Cmd.java PRE-CREATION
> 
> api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlerts
> Cmd.java PRE-CREATION
> 
> api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCm
> d.java PRE-CREATION
> 
> api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd
> .java PRE-CREATION
>   client/tomcatconf/commands.properties.in 5b387bd
>   core/src/com/cloud/alert/AlertVO.java f6089d6
>   core/src/com/cloud/event/EventVO.java ac46f24
>   core/src/com/cloud/event/dao/EventDao.java bfcb818
>   core/src/com/cloud/event/dao/EventDaoImpl.java 44fbb03
>   server/src/com/cloud/alert/dao/AlertDao.java eb1faa5
>   server/src/com/cloud/alert/dao/AlertDaoImpl.java 2f3be88
>   server/src/com/cloud/api/ApiDispatcher.java cf86afc
>   server/src/com/cloud/api/query/QueryManagerImpl.java 746e8cb
>   server/src/com/cloud/api/query/vo/EventJoinVO.java f29a942
>   server/src/com/cloud/configuration/Config.java 04ad640
>   server/src/com/cloud/server/ManagementServerImpl.java 0e53079
>   setup/db/db/schema-410to420.sql 6f68e12
> 
> Diff: https://reviews.apache.org/r/9753/diff/
> 
> 
> Testing
> -------
> 
> Tested the new API archiveAlerts, deleteAlerts, archiveEvents, deleteEvents
> with all the possible combinations of parameters as input on my local
> CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi

Mime
View raw message