Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57A9CE3B6 for ; Fri, 1 Feb 2013 07:09:13 +0000 (UTC) Received: (qmail 50761 invoked by uid 500); 1 Feb 2013 07:09:12 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 50725 invoked by uid 500); 1 Feb 2013 07:09:12 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 50695 invoked by uid 99); 1 Feb 2013 07:09:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2013 07:09:12 +0000 Date: Fri, 1 Feb 2013 07:09:12 +0000 (UTC) From: "Joe San (JIRA)" To: cloudstack-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-1080) Interface heirarchy for AccountManagerImpl superflous MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568535#comment-13568535 ] Joe San commented on CLOUDSTACK-1080: ------------------------------------- I just wanted to know if there are any guidelines set up by the entire project and agreed on some refactoring standards? If not, I can definitely come up with a proposal. How do you guys normally handle proposals? Should I create a new Jira or just send an email to the dev list with my ideas? I would rather like to have a Jira ticket for this discussion. > Interface heirarchy for AccountManagerImpl superflous > ----------------------------------------------------- > > Key: CLOUDSTACK-1080 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1080 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: API > Reporter: Joe San > Assignee: Rohit Yadav > Priority: Trivial > Labels: Refactoring > > The AccountManagerImpl.java has two interfaces in its implements clause which is a bit redundant. These two interfaces are already in the same heirarchy (AccountManager and AccountService). Can we refactor the AccountManagerImpl to implement only the AccountManager? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira