Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1192E995 for ; Tue, 26 Feb 2013 08:11:13 +0000 (UTC) Received: (qmail 6404 invoked by uid 500); 26 Feb 2013 08:11:13 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 6354 invoked by uid 500); 26 Feb 2013 08:11:13 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 6323 invoked by uid 99); 26 Feb 2013 08:11:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Feb 2013 08:11:12 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of Chiradeep.Vittal@citrix.com designates 66.165.176.63 as permitted sender) Received: from [66.165.176.63] (HELO SMTP02.CITRIX.COM) (66.165.176.63) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Feb 2013 08:11:05 +0000 X-IronPort-AV: E=Sophos;i="4.84,739,1355097600"; d="scan'208";a="9121200" Received: from sjcpmailmx01.citrite.net ([10.216.14.74]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/RC4-MD5; 26 Feb 2013 08:10:44 +0000 Received: from SJCPMAILBOX01.citrite.net ([10.216.4.72]) by SJCPMAILMX01.citrite.net ([10.216.14.74]) with mapi; Tue, 26 Feb 2013 00:10:43 -0800 From: Chiradeep Vittal To: "cloudstack-dev@incubator.apache.org" CC: "hugo@apache.org" Date: Tue, 26 Feb 2013 00:10:39 -0800 Subject: Re: [discuss] NetworkManager in migration Thread-Topic: [discuss] NetworkManager in migration Thread-Index: Ac4T+MX+GO5w+hitQIeH2+ndykzNWg== Message-ID: In-Reply-To: <512C2438.3020901@stratosphere.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.1.130117 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org On 2/25/13 6:55 PM, "KAWAI Hiroaki" wrote: >Hi, I'm writing a network plugin that tracks the location >of the virtual machine (and then reacts). > >There're interface methods in NetworkGuru and NetworkElement >that can be used for this purpose. > >The location of the virtual machine is provided by >DeployDestination, which will be passed in NetworkGuru#reserve >and NetworkElement#prepare. > >The two methods are called at the time VM starts up. The >problem is that, in migration those methods are not called. >There is NetworkManager#prepareNicForMigration, and it is >called before the VM migration. But NetworkManagerImpl >does not call NetworkGuru#reserve and NetworkElement#prepare. >This makes tracking the vm location impossible. Perhaps a little more information would help us understand this better? This doesn't seem to be a problem with current out-of-the-box vanilla VLAN based networks.=20 Anybody else (Hugo? Dave Cahill?) want to chime in? > >We need to add calls in NetworkManagerImpl. I can see the value of this, but a bit more explanation is required. > >And then, after the migration, NetworkGuru#release and >NetworkElement#release should be called, otherwise the >network resources that plugin reserved will be kept >even when the vm leaves off. This should be on the previous nic profile? > >So one more proposal is that we add one interface method >NetworkManager#releaseNicForMigrated to call those methods. > >To let the plugin Guru or Elements know it is migration or normal >server startup/shutdown, ReservationContext will be useful. > >Do this proposal make sense? >