Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of animesh.chaturvedi@citrix.com
 designates 66.165.176.89 as permitted sender)
From: Animesh Chaturvedi <animesh.chaturvedi@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>, Kelven Yang <kelven.yang@citrix.com>
CC: Murali Reddy <muralimmreddy@gmail.com>, Sateesh Chodapuneedi
	<sateesh.chodapuneedi@citrix.com>
Date: Thu, 21 Feb 2013 22:42:16 -0800
Subject: RE: Review Request: patch-3 for feature 'Support for VMware
 dvSwitch in CloudStack'.
Thread-Topic: Review Request: patch-3 for feature 'Support for VMware
 dvSwitch in CloudStack'.
Thread-Index: Ac4QxAZI+oa7H9u+RBKrBBhV3GCqSAAA6K9Q
Message-ID: 
 <7A92FF96DF135843B4B608FB576BFC3E012DA4606429@SJCPMAILBOX01.citrite.net>
References: <20130206011940.13217.22166@reviews.apache.org>
 <20130222021928.18986.19531@reviews.apache.org>
 <CANLSSBVp-7uO=Obt1AvED7Mp9ErTtDyU5FM+anv6YgkQF7jbUw@mail.gmail.com>
In-Reply-To: 
 <CANLSSBVp-7uO=Obt1AvED7Mp9ErTtDyU5FM+anv6YgkQF7jbUw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0


> -----Original Message-----
> From: rohityadav89@gmail.com [mailto:rohityadav89@gmail.com] On Behalf
> Of Rohit Yadav
> Sent: Thursday, February 21, 2013 10:15 PM
> To: cloudstack-dev@incubator.apache.org; Kelven Yang
> Cc: Murali Reddy; Sateesh Chodapuneedi
> Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSw=
itch
> in CloudStack'.
>=20
> It's unclear when a committer gives a ship it on reviewboard, they should=
 also
> include information on whether it is:
>=20
> - Ship it, but needs one more review
> - Ship it, and it's already merged on respective branch
> - Ship it and is not merged.
>=20
> Regards.
[Animesh>] Agreed I will put this in review board guidelines
>=20
> On Fri, Feb 22, 2013 at 7:49 AM, Kelven Yang <kelven.yang@citrix.com> wro=
te:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9196/#review16921
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Ship It!
> >
> > - Kelven Yang
> >
> >
> > On Feb. 6, 2013, 1:19 a.m., Sateesh Chodapuneedi wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9196/
> >> -----------------------------------------------------------
> >>
> >> (Updated Feb. 6, 2013, 1:19 a.m.)
> >>
> >>
> >> Review request for cloudstack, Murali Reddy and Kelven Yang.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is 3rd patch for feature 'Support for VMware dvSwitch in CloudSta=
ck'.
> >> This patch contains few helper functions (get dvswitch reference, chec=
k the
> type of a port group). Also added method getType() to VirtualSwitchType e=
num.
> >>
> >>
> >> This addresses bug CLOUDSTACK-657.
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java
> eb10e16
> >>   vmware-
> base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff
> >>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
> >> 47ff8e2
> >>
> >> Diff: https://reviews.apache.org/r/9196/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Manual testing:-
> >> 1) Tested guest traffic over dvSwitch on a dedicated physical network.=
 In this
> case management and public traffic uses standard vSwitch on a common
> physical network.
> >> 2) Tested both guest traffic and public traffic over dvSwitch on a phy=
sical
> network.
> >> 3) Use optional parameters added to AddClusterCmd to override Zone lev=
el
> network traffic label. Tested 2 clusters, one with standard vSwitch and o=
ther
> with dvSwitch.
> >> 4) Tested all 3 traffic types on single physical network with global p=
arameter
> 'vmware.use.dvswitch' set to false. This is default configuration scenari=
o.
> >>
> >>
> >> Added following tests,
> >> 1) Test fetching dvSwitch object from vCenter
> >> 2) Test for presence of dvPortGroup
> >> 3) Test presence of dvPortGroup
> >> 4) Test get existing dvPortGroup
> >> 5) fetch dvPortGroup configuration
> >> 6) Test compare dvPortGroup configuration
> >> 7) Test update dvPortGroup configuration
> >>
> >>
> >> Thanks,
> >>
> >> Sateesh Chodapuneedi
> >>
> >>
> >