Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of animesh.chaturvedi@citrix.com
 designates 66.165.176.63 as permitted sender)
From: Animesh Chaturvedi <animesh.chaturvedi@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>, David Nalley <david@gnsa.us>
CC: Chip Childers <chip.childers@sungard.com>, Prasanna Santhanam
	<Prasanna.Santhanam@citrix.com>, Alex Huang <Alex.Huang@citrix.com>, mice xia
	<mice_xia@tcloudcomputing.com>, Chiradeep Vittal <chiradeepv@gmail.com>,
	Meghna Kale <meghna.kale@sungard.com>
Date: Mon, 11 Feb 2013 23:02:31 -0800
Subject: RE: Review Request: Added Unit test cases for com.cloud.api.commands
Thread-Topic: Review Request: Added Unit test cases for
 com.cloud.api.commands
Thread-Index: Ac3eH5N0tB+0zTYHTMmvm3kxbQXHSwqz1GtA
Message-ID: 
 <7A92FF96DF135843B4B608FB576BFC3E012DA42B250B@SJCPMAILBOX01.citrite.net>
References: <20121212105620.7759.39423@reviews.apache.org>
 <20121219035920.20143.86959@reviews.apache.org>
 <CAKprHVYtQGWyZOT8gmd5aUp9YwpoAU=Tm6AFMaW0sq8r8fWnDQ@mail.gmail.com>
 <F9A3F68D-CAF9-4DBF-B182-708BB1C5A1AE@citrix.com>
In-Reply-To: <F9A3F68D-CAF9-4DBF-B182-708BB1C5A1AE@citrix.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Meghna

While I was going through the review board I saw this was last updates over=
 a month ago, Do you have any updates?

Animesh

> -----Original Message-----
> From: Rohit Yadav [mailto:rohit.yadav@citrix.com]
> Sent: Wednesday, December 19, 2012 11:32 AM
> To: David Nalley
> Cc: cloudstack-dev@incubator.apache.org; Chip Childers; Prasanna Santhana=
m;
> Alex Huang; mice xia; Chiradeep Vittal; Meghna Kale
> Subject: Re: Review Request: Added Unit test cases for
> com.cloud.api.commands
>=20
>=20
> On 19-Dec-2012, at 8:36 AM, David Nalley <david@gnsa.us> wrote:
>=20
> > On Tue, Dec 18, 2012 at 10:59 PM, Rohit Yadav <rohit.yadav@citrix.com>
> wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/8545/#review14711
> >> -----------------------------------------------------------
> >>
> >>
> >> Thanks for your patch, but your changes are not applying cleanly and w=
ill
> break both api_refactoring and javelin.  I will have to merge the
> api_refactoring branch soon else there will be pile of review with a lot =
of
> merge conflicts.
> >>
> >> My target was to merge api_refactoring yesterday but I thought I would=
 fix
> some more stuff before I merge it on master
>=20
> See below:
>=20
> >> so it won't break anything on master.
> >> If you already working on some other unit tests pl. work on the
> api_refactoring branch, I'm planning to send a merge request and progress
> report on dev ML this weekend.
> >>
> >> - Rohit Yadav
> >>
> >
> > Please discuss this on list before you attempt a merge.
>=20
> Yes, as I mentioned I'll send a merge request before doing it i.e. ask co=
mmunity
> to checkout the code comment on merge etc. Meanwhile, any patch related t=
o
> api layer, anything like unit tests etc. should be done on api_refactorin=
g to
> avoid merge conflicts without waiting for the actual merge on master.
>=20
> > Something of
> > this magnitude should not happen without some degree of notice.
>=20
> I understand your concern but I think it won't be any major issue as the =
merge
> conflicts on master (as of now) are about 100-200 and the only significan=
t
> changes are package renames, and annotations.
>=20
> Regards.
>=20
> >
> > --David